[NFC] Shift ZOS libcall declarations to llvm/include #144672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 0a3e9aa this moved to llvm/lib/IR, but other .def files are in the include directory, so shift it there.
Member
|
@llvm/pr-subscribers-llvm-ir Author: Jeremy Morse (jmorse) ChangesHola -- in #142622 this ZOS definitions file shifted out of a machine-specific directory to llvm/lib/IR, where it sort of stands out for being the only .def file, and the only OS-specific file. I feel it's better placed in llvm/include/llvm/IR where there are other .def files and declarations for other OS/machine specific things. Full diff: https://github.com/llvm/llvm-project/pull/144672.diff 2 Files Affected:
diff --git a/llvm/lib/IR/ZOSLibcallNames.def b/llvm/include/llvm/IR/ZOSLibcallNames.def
similarity index 100%
rename from llvm/lib/IR/ZOSLibcallNames.def
rename to llvm/include/llvm/IR/ZOSLibcallNames.def
diff --git a/llvm/lib/IR/RuntimeLibcalls.cpp b/llvm/lib/IR/RuntimeLibcalls.cpp
index 7396626a03d41..7e810b2857985 100644
--- a/llvm/lib/IR/RuntimeLibcalls.cpp
+++ b/llvm/lib/IR/RuntimeLibcalls.cpp
@@ -609,7 +609,7 @@ void RuntimeLibcallsInfo::initLibcalls(const Triple &TT) {
};
static RTLibCallMapping RTLibCallCommon[] = {
#define HANDLE_LIBCALL(code, name) {RTLIB::code, name},
-#include "ZOSLibcallNames.def"
+#include "llvm/IR/ZOSLibcallNames.def"
};
for (auto &E : RTLibCallCommon)
setLibcallName(E.Code, E.Name);
|
arsenm
requested changes
Jun 18, 2025
Contributor
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
Don't bother touching this, I have a stack of patches to replace this all with tablegen
Member
Author
|
Very good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola -- in #142622 this ZOS definitions file shifted out of a machine-specific directory to llvm/lib/IR, where it sort of stands out for being the only .def file, and the only OS-specific file. I feel it's better placed in llvm/include/llvm/IR where there are other .def files and declarations for other OS/machine specific things.